Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call ObserveDuration more than one in the observable proxy #1666

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Don't call ObserveDuration more than one in the observable proxy #1666

merged 1 commit into from
Nov 28, 2023

Conversation

josephschorr
Copy link
Member

Fixes #1664

@josephschorr josephschorr requested a review from a team November 28, 2023 18:10
@github-actions github-actions bot added the area/datastore Affects the storage system label Nov 28, 2023
@vroldanbet vroldanbet enabled auto-merge November 28, 2023 18:16
@vroldanbet vroldanbet added this pull request to the merge queue Nov 28, 2023
Merged via the queue into authzed:main with commit 6e1677c Nov 28, 2023
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
@josephschorr josephschorr deleted the observable-proxy branch November 28, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not observe histogram duration multiple times during Close()
2 participants
@josephschorr @vroldanbet